This repository has been archived by the owner on Jul 15, 2021. It is now read-only.
Make request header blacklist case insensitive #202
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
thewilkybarkid
commented
Mar 30, 2017
thewilkybarkid
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | Apache License 2.0 |
Avariya
approved these changes
Mar 30, 2017
|
Actually, this is a BC break, as it changes the file naming strategy. |
thewilkybarkid
force-pushed
the
mock-storage-header-case
branch
from
a2c2226
to
4ee31a9
Compare
|
Ok, I've changed it so it tries normalising the request headers first, and falls back to not normalising. |
|
We're nearly there! Could you add a test to check that both the new and the old naming strategies return the expected paths? Thanks! 😃 |
csarrazi
reviewed
Apr 10, 2017
| @@ -66,8 +66,9 @@ public function testFetch() | |||
| public function testSave() | |||
| { | |||
| $request = $this->getRequestMock(); | |||
| $mockStorage = new $this->class($this->tmpDir, [], ['X-Foo']); | |||
There was a problem hiding this comment.
This test should not be altered.
On the other hand, we should create tests which test specifically the naming strategies.
|
I'm closing this PR as the logic has been moved to a third-party library. @thewilkybarkid Want to make a PR against the new project? (https://github.com/csarrazi/guzzle-cache-middleware) :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.