Complete (#867)

cscenter · Aug 19, 2024 · c5446d8 · c5446d8
1 parent b8a5231
commit c5446d8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/apps/learning/signals.py b/apps/learning/signals.py
@@ -26,7 +26,7 @@ def manage_student_group_for_course_root_branch(sender, instance, created,
 @receiver(post_save, sender=CourseBranch)
 def create_student_group_from_course_branch(sender, instance: CourseBranch,
                                             created, *args, **kwargs):
-    if created and instance.course.group_mode == CourseGroupModes.BRANCH:
+    if created and instance.course.group_mode in [CourseGroupModes.BRANCH, CourseGroupModes.INVITE_AND_BRANCH]:
         StudentGroupService.create(instance.course,
                                    group_type=StudentGroupTypes.BRANCH,
                                    branch=instance.branch)

diff --git a/apps/learning/tests/test_student_groups.py b/apps/learning/tests/test_student_groups.py
@@ -65,11 +65,12 @@ def test_create_student_group_from_main_branch(settings):
 
 
 @pytest.mark.django_db
-def test_upsert_student_group_from_additional_branch(settings):
+@pytest.mark.parametrize("group_mode", [CourseGroupModes.BRANCH, CourseGroupModes.INVITE_AND_BRANCH])
+def test_upsert_student_group_from_additional_branch(settings, group_mode):
     branch_spb = BranchFactory(code=Branches.SPB)
     branch_nsk = BranchFactory(code=Branches.NSK)
     course = CourseFactory(main_branch=branch_spb,
-                           group_mode=StudentGroupTypes.BRANCH)
+                           group_mode=group_mode)
     assert StudentGroup.objects.filter(course=course).count() == 1
     CourseBranch(course=course, branch=branch_nsk).save()
     groups = StudentGroup.objects.filter(course=course)