Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multicasskop fixes #29

Merged
merged 1 commit into from
Apr 7, 2022
Merged

Conversation

AKamyshnikova
Copy link
Collaborator

Fix crd name and drop files that are not used.

Restore dropped PROJECT in main directory.

Q A
Bug fix? [x]
New feature? []
API breaks? []
Deprecations? []
Related tickets fixes #X, partially #Y, mentioned in #Z
License Apache 2.0

What's in this PR?

Fix issues that were introduced with operator-sdk bump, see
Orange-OpenSource/casskop#376 (comment)

Checklist

  • Implementation tested
  • Logging code meets the guideline
  • User guide and development docs updated (if needed)
  • Append changelog

Fix crd name and drop files that are not used.

Restore dropped PROJECT in main directory.
@cscetbon
Copy link
Owner

@AKamyshnikova how are those PROJECT files needed ? When I ran not-missing-manifests without those I don't see any missing files or any differences. Can you elaborate on this ?

@AKamyshnikova
Copy link
Collaborator Author

AKamyshnikova commented Mar 29, 2022

@cscetbon

A PROJECT configuration file to store information about GVKs, plugins, and help the CLI make decisions.
https://sdk.operatorframework.io/docs/building-operators/golang/migration/#what-is-new

If you try to run operator-sdk cli commands without existing PROJECT file(in case you want create new api, webhook) you will get an error.
FATA[0000] failed to create API: unable to load configuration file: unable to load the configuration: unable to read "PROJECT" file: open PROJECT: no such file or directory

@cscetbon
Copy link
Owner

If you try to run operator-sdk cli commands without existing PROJECT file(in case you want create new api, webhook) you will get an error. FATA[0000] failed to create API: unable to load configuration file: unable to load the configuration: unable to read "PROJECT" file: open PROJECT: no such file or directory

Can you tell me more about the commands that we need to run now ? Cause I then need to update https://github.com/cscetbon/casskop/blob/master/.github/workflows/tests-and-docker-images.yml#L20-L58. This test didn't catch the missing PROJECT so I imagine it doesn't really do anything with the new operator-sdk

@AKamyshnikova
Copy link
Collaborator Author

@cscetbon
make generate uses controller-gen for generating crds and k8s projects as expected.
Error with missing PROJECT would appear if we wanted to create new API, webhook, etc using operator-sdk cli https://sdk.operatorframework.io/docs/cli/
So, having PROJECT is mostly meaningful in turns of development new things using operator-sdk functionality.
There is a feature named operator-sdk bundle https://sdk.operatorframework.io/docs/cli/operator-sdk_bundle/
I didn't adopt it for casskop with bump of operator-sdk. I guess operator-sdk bundle validate can be used as a test.
If you think it is a valid thing to do I can add PR for that.

@cscetbon
Copy link
Owner

There is a feature named operator-sdk bundle https://sdk.operatorframework.io/docs/cli/operator-sdk_bundle/
I didn't adopt it for casskop with bump of operator-sdk. I guess operator-sdk bundle validate can be used as a test.
If you think it is a valid thing to do I can add PR for that.

I saw you've added that command in multi-casskop but not in Casskop. So yes let's do it and use it to add validation

Thanks

@cscetbon cscetbon merged commit bfe853d into cscetbon:master Apr 7, 2022
@AKamyshnikova AKamyshnikova deleted the multicasskop-fix branch March 11, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants