-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multicasskop fixes #29
Conversation
Fix crd name and drop files that are not used. Restore dropped PROJECT in main directory.
@AKamyshnikova how are those PROJECT files needed ? When I ran not-missing-manifests without those I don't see any missing files or any differences. Can you elaborate on this ? |
If you try to run operator-sdk cli commands without existing PROJECT file(in case you want create new api, webhook) you will get an error. |
Can you tell me more about the commands that we need to run now ? Cause I then need to update https://github.com/cscetbon/casskop/blob/master/.github/workflows/tests-and-docker-images.yml#L20-L58. This test didn't catch the missing PROJECT so I imagine it doesn't really do anything with the new operator-sdk |
@cscetbon |
I saw you've added that command in multi-casskop but not in Casskop. So yes let's do it and use it to add validation Thanks |
Fix crd name and drop files that are not used.
Restore dropped PROJECT in main directory.
What's in this PR?
Fix issues that were introduced with operator-sdk bump, see
Orange-OpenSource/casskop#376 (comment)
Checklist