Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tests #16

Merged
merged 81 commits into from
Oct 16, 2022
Merged

Refactor tests #16

merged 81 commits into from
Oct 16, 2022

Conversation

cschreib
Copy link
Owner

@cschreib cschreib commented Oct 2, 2022

This PR does the following:

  • The explicit casting constructor of oup::basic_observable_ptr would not move the deleter. This is now fixed.
  • A call to oup::dynamic_pointer_cast on a null pointer would not move the deleter. This is now fixed.
  • MSVC would report a false positive warning about a noexcept function that can throw. The warning is now silenced.
  • Improved error message for over-aligned types in oup::make_observable.
  • (internal only) Improved encapsulation of the ptr_and_deleter object.
  • (internal only) Refactored the tests; using snatch instead of Catch2.

@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2022

Codecov Report

Merging #16 (f82e691) into main (7a16d59) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #16   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          317       347   +30     
=========================================
+ Hits           317       347   +30     
Impacted Files Coverage Δ
include/oup/observable_unique_ptr.hpp 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a16d59...f82e691. Read the comment docs.

@cschreib cschreib merged commit 3b90166 into main Oct 16, 2022
@cschreib cschreib deleted the update branch October 16, 2022 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants