macOS Support #534
macOS Support #534
Conversation
This reverts commit f0ac94e.
There was a problem hiding this comment.
I'm excited about MacOS support, thanks for doing the work. I'd definitely like to merge. I've only had a quick look at this PR as it is quite large but I don't understand yet how it provides MacOS support. Could you point me at the two or three relevant files so I can review? So far I mostly see file deletions but not corresponding additions.
|
@sowens-csd I was able to implement macOS support by using the shared Darwin approach as mentioned in the flutter docs: https://docs.flutter.dev/packages-and-plugins/developing-packages#shared-ios-and-macos-implementations. Both iOS and macOS use the same code with some slight differences based off their platforms. Take a look at the speech_to_text/darwin/Classes/SpeechToTextPlugin.swift file for the implementation. |
|
@sowens-csd any plans to merge and launch it in a new version of the flutter package? Are you aware of speech_to_text_macos? |
|
@alibad "speech_to_text_macos" is no longer needed because of the shared darwin implementation in this pr |
| <true/> | ||
| <key>com.apple.security.device.audio-input</key> | ||
| <true/> | ||
| <key>com.apple.security.network.server</key> |
There was a problem hiding this comment.
should this also include
<key>com.apple.security.network.client</key>
<true/>
There was a problem hiding this comment.
To run the debug version of the audio_player_interaction on macOS the network.client. key is not needed.
There was a problem hiding this comment.
Even when speech recognition is not running locally on the device?
There was a problem hiding this comment.
Correct, when I tested locally that key is not needed when running on device.
| @@ -0,0 +1,43 @@ | |||
| platform :osx, '10.14' | |||
There was a problem hiding this comment.
The plugin can be built on macOS 10.13 and above but the speech recognition code only works on macOS 10.15 and above.
When I generated the macOS project the pod file automatically set the platform as 10.14
| @@ -1,5 +1,5 @@ | |||
| # Uncomment this line to define a global platform for your project | |||
| # platform :ios, '11.0' | |||
| # platform :ios, '12.0' | |||
There was a problem hiding this comment.
Probably not. When I generated the macOS project in the example it updated the platform numbers. Do you want me to revert it?
There was a problem hiding this comment.
I personally think it's fine, unless @sowens-csd has reasons not to
|
@alibad I ran the example projects on iOS and macOS on my Mac. I made sure text was returned from the plugin. |
|
@sowens-csd can you please approve this change? I'd like to use it as soon as the new version comes out. |
|
@alexrabin-sentracam I've merged the PR and am trying to run the example on MacOS. I've tried it from Xcode after a clean build and the app appears but clicking initialize does not appear to do anything. No errors in the log. So far I've been unable to get the debugger to stop on any lines inside the .swift. Any tips on how you tested that might help? |
|
@sowens-csd I pulled the latest code and I was able to get it to work correctly in Xcode. What macOS version are you on? I am on macOS 14.5 |
|
@sowens-csd make sure to run
|
|
Thanks for the assist, working well now. I'll add that to the README in case anyone is as much of an idiot as I. Thanks so much for doing this work. It's going to be in the 7.0.0 release of the plugin. |
|
Happy to help! |
|
Exciting! @sowens-csd when will the 7.0.0 release of the plugin take place? I'd like to pull it right away to test the MacOS behavior. |
|
7.0.0-beta.1 is available now. |
|
I just tested the beta. Before, I would get an initialize error. Now, the app crashes without any errors logged |
|
Did you run it from Xcode or VSCode? There's apparently a permissions problem that prevent Mac apps from working unless run from Xcode. |
|
Yes, it works from there |
|
@sowens-csd you might want to mention higher up in the ReadMe that MacOS only works when being run from Xcode. |
Addresses #231
This pr adds macOS support with a HUGE caveat.
This functionality only works when running the app directly from Xcode. There is a known issue with flutter that the macOS app crashes when requesting permissions in VSCode flutter/flutter#70374.
I leave this up to the author on if they want to merge this or not. But the functionality does exist.