Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rio accessor for geospatial information #47

Merged
merged 9 commits into from
Aug 11, 2022
Merged

Conversation

mdpiper
Copy link
Member

@mdpiper mdpiper commented Jul 30, 2022

This PR updates bmi-topography to use the rioxarray rio accessor for geopspatial information.

@mdpiper
Copy link
Member Author

mdpiper commented Jul 31, 2022

@mcflugen What would you think about allowing BMI grid spacing to have negative values? Currently, grid spacing is the distance (so a positive value) between the nodes of a grid along a coordinate axis. The issue is geospatial imagery usually treats the top left corner as the origin. A negative y-value for the grid spacing would indicate the grid is built from this origin in the negative y direction.

@mcflugen
Copy link
Member

mcflugen commented Aug 8, 2022

@mcflugen What would you think about allowing BMI grid spacing to have negative values?

I think we've done this before, actually. I'm not sure, however, if pymt supports it or if the bmi-tester is ok with it (but I think I am ok with it).

@mdpiper
Copy link
Member Author

mdpiper commented Aug 8, 2022

I think we've done this before, actually. I'm not sure, however, if pymt supports it or if the bmi-tester is ok with it (but I think I am ok with it).

The bmi-tester doesn't like it. Would it be OK if I submitted a PR to change this?

@mdpiper
Copy link
Member Author

mdpiper commented Aug 11, 2022

Until #49 is resolved, I'm disabling testing on Windows with python=3.10.

@mdpiper mdpiper merged commit 5ea4940 into main Aug 11, 2022
@mdpiper mdpiper deleted the mdpiper/use-rio-accessor branch August 11, 2022 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants