Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: GitHub workflows fail to build container-images for multiple architectures #92

Open
nixpanic opened this issue Jan 19, 2022 · 4 comments
Labels
testing Improvements for CI and testing

Comments

@nixpanic
Copy link
Collaborator

#89 changed how architectures are passed to the GitHub workflows. It seems that #91 was built only on one platform, instead of linux/amd64, linux/arm64 and linux/arm/v7.

For some reason the secrets.BUILD_PLATFORMS does not seem to be set for GitHub Actions?

@nixpanic
Copy link
Collaborator Author

Maybe there is some GitHub access limitation:

You can use and read encrypted secrets in a workflow file if you have access to edit the file.

The user creating the PR, will not have access to edit the file directly. Creating a PR from a branch in the local repository (#90) did work. That branch might have "access to edit the file"?

@nixpanic
Copy link
Collaborator Author

The behaviour is intentional and documented in a GitHub security guide:

Workflows triggered using the pull_request event have read-only permissions and have no access to secrets.

We'll need to think of an other way to limit building for multiple platforms.

@Madhu-1
Copy link
Member

Madhu-1 commented Jan 19, 2022

Yes due to security reason its done, sorry i forgot about it :( do we need to revert back to the PR introduced this one?

@nixpanic
Copy link
Collaborator Author

Yes due to security reason its done, sorry i forgot about it :( do we need to revert back to the PR introduced this one?

Reverting is probably not needed. The builds after merging build all platforms, so that is fine for now.

I'd like some way of configuring it in a single place, so that it is easy to adjust in forks of this repo. Just not sure what/where that configuration should be done.

@nixpanic nixpanic added the testing Improvements for CI and testing label Jul 29, 2022
nixpanic pushed a commit to nixpanic/kubernetes-csi-addons that referenced this issue Jan 12, 2024
Syncing latest changes from main for kubernetes-csi-addons
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Improvements for CI and testing
Projects
None yet
Development

No branches or pull requests

2 participants