Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated docs and removed unnecessary lines #21

Merged
merged 1 commit into from
Jul 28, 2024
Merged

updated docs and removed unnecessary lines #21

merged 1 commit into from
Jul 28, 2024

Conversation

avaelo
Copy link
Contributor

@avaelo avaelo commented Jul 28, 2024 •
edited by tanhongit
Loading

Summary

  • removed unnecessary command lines in the route file
  • update tips comment

Unit Testing

Operation check

Caution

Release Notes

Note

Additional Notes

Checklist

  • Code follows our Coding Standards.
  • Code matches the confirmed solution in the ticket.
  • Unit/Integration tests have been added or updated.
  • Env/Config/DB changes were confirmed by @cslant/admin.

@tanhongit tanhongit added the proposal A suggestion or plan for a new feature, improvement, or change in the existing system or project label Jul 28, 2024
@tanhongit tanhongit linked an issue Jul 28, 2024 that may be closed by this pull request
First generate core package #1
Closed
tanhongit
tanhongit approved these changes Jul 28, 2024
View reviewed changes
Copy link
Member

@tanhongit tanhongit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@avaelo thank you for your PR!!

@tanhongit tanhongit merged commit a7c3574 into cslant:main Jul 28, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanhongit tanhongit tanhongit approved these changes

Assignees

@avaelo avaelo

Labels
proposal A suggestion or plan for a new feature, improvement, or change in the existing system or project
Projects
Blog
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

First generate core package
2 participants
@avaelo @tanhongit