Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement pass_defines (fixed) #110

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

oriceemple
Copy link
Contributor

No description provided.

@eeide eeide self-assigned this Jul 25, 2016
@regehr
Copy link
Member

regehr commented Jul 26, 2016

continuing the discussion, my opinion is that depending on clang is perfectly OK since we already expect clang-format to exist

@regehr
Copy link
Member

regehr commented Jul 26, 2016

also, as Eric says, squashing at the end is the preferred workflow. github also has an auto-squash on merge feature that I haven't tried yet.

@regehr
Copy link
Member

regehr commented Jul 26, 2016

It's an interesting approach. Can you share some examples where this approach works but where it wasn't possible to preprocess before running C-Reduce?

@oriceemple
Copy link
Contributor Author

I can't give exact details, but I can explain where pass_defines helps me:

  1. It allows reducing work in the pass_unifdef phase.
  2. When testing code that uses precompiled headers, we want to continue running through the precompiled header path instead of forcing everything to go in the cpp.
  3. A reduce that depends on file-specific behaviour, such as #pragma GCC system_header will misbehave after preprocessing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants