clean up TODOs

cspotcode · May 1, 2022 · 990c03d · 990c03d
1 parent 50c71dd
commit 990c03d
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/source-map-support.js b/source-map-support.js
@@ -129,8 +129,6 @@ function hasGlobalProcessEventEmitter() {
 }
 
 function tryFileURLToPath(v) {
-  // TODO technically, file URL can omit /s.
-  // Copy the isFileURL util from resolve-uri?
   if(isFileUrl(v)) {
     return fileURLToPath(v);
   }
@@ -154,8 +152,7 @@ function isSchemeRelativeUrl(input) {
 /** @param {string} pathOrFileUrl */
 function getCacheKey(pathOrFileUrl) {
   if(pathOrFileUrl.startsWith('node:')) return pathOrFileUrl;
-  // TODO unify with isFileURL checks elsewhere?  as helper fn?
-  if(pathOrFileUrl.startsWith('file:/')) {
+  if(isFileUrl(pathOrFileUrl)) {
     // Must normalize spaces to %20, stuff like that
     return new URL(pathOrFileUrl).toString();
   } else {

diff --git a/test.js b/test.js
@@ -390,7 +390,6 @@ it('eval', async function() {
   ], [
     'Error: test',
 
-    // TODO
     re`^    at eval \(eval at (<anonymous>|exports\.test|test) \(${stackFramePathStartsWith()}(?:.*[/\\])?line1\.js:1001:101\)`,
 
     re`^    at ${stackFrameAtTest()} \(${stackFramePathStartsWith()}(?:.*[/\\])?line1\.js:1001:101\)$`
-Original file line number
+Diff line change
@@ Expand Up / @@ -390,7 +390,6 @@ it('eval', async function() { @@
       ], [
         'Error: test',
-        // TODO
         re`^    at eval \(eval at (<anonymous>|exports\.test|test) \(${stackFramePathStartsWith()}(?:.*[/\\])?line1\.js:1001:101\)`,
         re`^    at ${stackFrameAtTest()} \(${stackFramePathStartsWith()}(?:.*[/\\])?line1\.js:1001:101\)$`
@@ Expand Down @@