-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File tree restructure #17
base: master
Are you sure you want to change the base?
Conversation
doc/source/.* | ||
!doc/source/*.rst | ||
!doc/source/conf.py | ||
|
||
# Include all non-build documentation files | ||
!doc/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @pritkc , thank you for your work. I would just remove these lines and for now leave only your line 14, where we exclude the doc/build
path.
You also want to exclude the path that you have specified in your Doxyfile: in the HTML_OUTPUT
variable, that is HTML_OUTPUT = doc/api_docs/cpp
doc/source/.* | |
!doc/source/*.rst | |
!doc/source/conf.py | |
# Include all non-build documentation files | |
!doc/ | |
doc/api_docs/cpp |
Hi @jbrzensk , please make sure that you are ok with the proposed changes to the directory structure. Basically, @pritkc is proposing to simplify the nomenclature for the different flavors directly as subdirectory names. E.g.:
And similarly, for the examples and test directories:
and
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many of the MATLAB examples and all of the tests have the MOLE library location coded in, to run without adding the library to the MATLAB path.
If the folder locations are changed, each of the references in the code must also be updated.
clc | ||
close all | ||
|
||
addpath('../../src/mole_MATLAB') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This folder no longer exists. The mole source directory is hard coded into all of the MATLAB examples. If you change the name, all the MATLAB files need the reference changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, the tests have the location of the source MATLAB hard coded. If you change the source location, they must be changed in the test files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Source location incorrect
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Source location incorrect
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Source location incorrect
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Source location incorrect
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The source location is incorrect. I am going to stop commenting here, because there are many filepath changes to be made.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jbrzensk, thank you for catching that oversight! I noticed there are at least 32 instances that need updating. While we're discussing this, I’d appreciate your thoughts on whether adopting this unified nomenclature is worth any potential inconvenience for future legacy contributors.
Are we including the generated doxygen files in the repository or letting the user create the doxygen files for C++? |
Hi @jbrzensk , yes, the main idea is to follow libCEED documentation model. We will have step-by-step instructions like libCEED does to explain how to build the documentation. And yes, it's a 2-step build process. First one builds the Doxygen API docs, by running, say, |
@valeriabarra I see you addressed this in the .gitignore comment above, sorry. |
libCEED
.doc/
folder.config.py file
for the C++ Doxygen documentation to reflect the new directory structure.config.py
to resolve deprecation warnings with lthe atest version.Makefiles
.README.md
.gitignore
.resolves #16