Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed relative paths #5

Merged
merged 1 commit into from
Jun 9, 2015
Merged

Fixed relative paths #5

merged 1 commit into from
Jun 9, 2015

Conversation

rtsao
Copy link
Contributor

@rtsao rtsao commented Jun 8, 2015

In the https://github.com/css-modules/browserify-demo repo, all the composes are commented out, for example:

StyleVariantA.css

.root {
  /*composes: box from "../../../shared/styles/layout.css";*/
  border-color: red;
}

.text {
  /*composes: heading from "../../../shared/styles/typography.css";*/
  color: red;
}

Uncommenting these lines results in ENOENT on build.

This PR fixes the resolution of these relative paths if we uncomment them.

@rtsao rtsao closed this Jun 8, 2015
@rtsao rtsao reopened this Jun 9, 2015
@markdalgleish
Copy link
Member

Could you squash these into a single commit? No need for us to merge in a broken commit :)

@rtsao
Copy link
Contributor Author

rtsao commented Jun 9, 2015

Oops forgot to do that, I've gotten too used to Phabricator and having Arcanist do that automatically. I've just fixed that.

@geelen
Copy link
Member

geelen commented Jun 9, 2015

Looks good to me!

geelen added a commit that referenced this pull request Jun 9, 2015
@geelen geelen merged commit 7f660e7 into css-modules:master Jun 9, 2015
@markdalgleish
Copy link
Member

Nice work—thanks so much for fixing this @rtsao, this issue was next on my list 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants