Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stylelint peer dependency to include stylelint 15 #35

Merged

Conversation

alex-e-leon
Copy link
Contributor

Bumps peer dependency to fix: #32

Some quick testing suggests that this plugin works fine with stylelint 15

@alex-e-leon
Copy link
Contributor Author

For anyone waiting on this, feel free to use my published fork:
@alex-e-leon/stylelint-value-no-unknown-custom-properties": "^4.0.2"

@alex-e-leon
Copy link
Contributor Author

Hey @Antonio-Laguna - this should be an easy PR to approve - I've been running this branch for the last few weeks and can confidently say that this plugin still works fine with stylelint 15.

Any chance you can get this merged in?

@jameschensmith
Copy link
Contributor

I'm not able to approve (don't have write access), but LGTM 👍

Also, just a note: a very basic implementation of this has been added to stylelint (you can view the details in the initial MR). This tracking issue would probably need to be close for the built-in rule to completely replace this rule.

@alex-e-leon
Copy link
Contributor Author

Thanks @jameschensmith : )
I know that at least for my usecase, and probably most people who use css-modules, not being able to track definitions in other files would be a dealbreaker.

@Antonio-Laguna
Copy link
Member

Thanks @alex-e-leon ! Apologies this took me a while!

@Antonio-Laguna Antonio-Laguna merged commit 9c50fb2 into csstools:main Nov 6, 2023
@alex-e-leon alex-e-leon deleted the update-stylelint-peer-dep branch November 6, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stylelint v15
3 participants