-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update stylelint peer dependency #53
Conversation
Latest version of stylelint is 15.2.0
I understand the idea of limiting the version range, but if this was my package I would just say
Unless you are actively monitoring and testing peer dependency changes for compatibility the way that happens is to allow your users to be the QA and test the latest versions. With modern npm peerDependency resolutions it is difficult to install something newer than your range in the CI systems that run my automated tests which would let me know if there are problems. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW I can confirm that the current version of. stylelint-csstree-validator
works with Stylelint 15 on all of my projects
Good news! There's a built-in rule in Stylelint 15: Unfortunately, that rule works on ly with CSS and doesn't support SASS/LESS: https://stylelint.io/user-guide/rules/declaration-property-value-no-unknown/
Here's what I did for my projects: sweetalert2/stylelint-config@b17a7f4 + sweetalert2/stylelint-config@969616c (hack to ignore SCSS variables) |
Does that include SCSS/SASS support? |
no |
Seems like this one does so it is still useful stylelint-validator/lib/index.js Line 18 in c7fac4f
|
You're right, I've updated my previous comment, thanks 👍 |
Any chance this can be merged soon? I am blocked in updating stylelint by this dependency. |
Any update on this? |
I added this to my package.json to work around this apparently dead project. "devDependencies": {
"stylelint-csstree-validator": "^2.1.0"
},
"overrides": {
"stylelint-csstree-validator@^2.1.0": {
"stylelint@>=7.0.0 <15.0.0": "*"
}
} |
Very sorry in delay for an update. That's fixed in v3.0.0. The fix is also required to drop older versions of Node.js, that's why it's a major version bump due to semver. |
Latest version of stylelint is 15.2.0