Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stylelint peer dependency #53

Closed
wants to merge 1 commit into from
Closed

Update stylelint peer dependency #53

wants to merge 1 commit into from

Conversation

rgant
Copy link

@rgant rgant commented Feb 22, 2023

Latest version of stylelint is 15.2.0

Latest version of stylelint is 15.2.0
@rgant
Copy link
Author

rgant commented Feb 22, 2023

I understand the idea of limiting the version range, but if this was my package I would just say

stylelint": ">=7.0.0"

Unless you are actively monitoring and testing peer dependency changes for compatibility the way that happens is to allow your users to be the QA and test the latest versions. With modern npm peerDependency resolutions it is difficult to install something newer than your range in the CI systems that run my automated tests which would let me know if there are problems.

@rgant rgant mentioned this pull request Feb 27, 2023
Copy link
Contributor

@limonte limonte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW I can confirm that the current version of. stylelint-csstree-validator works with Stylelint 15 on all of my projects

@limonte
Copy link
Contributor

limonte commented Mar 7, 2023

Good news!

There's a built-in rule in Stylelint 15: declaration-property-value-no-unknown that is doing the same thing.

Unfortunately, that rule works on ly with CSS and doesn't support SASS/LESS:

https://stylelint.io/user-guide/rules/declaration-property-value-no-unknown/

This rule is only appropriate for CSS. You should not turn it on for CSS-like languages, such as Sass or Less, as they have their own syntaxes.

Here's what I did for my projects: sweetalert2/stylelint-config@b17a7f4 + sweetalert2/stylelint-config@969616c (hack to ignore SCSS variables)

@rgant
Copy link
Author

rgant commented Mar 7, 2023

Does that include SCSS/SASS support?

@limonte
Copy link
Contributor

limonte commented Mar 7, 2023

Does that include SCSS/SASS support?

no

@rgant
Copy link
Author

rgant commented Mar 7, 2023

Seems like this one does so it is still useful

sass: sassExtendedSyntax,

@limonte
Copy link
Contributor

limonte commented Mar 8, 2023

Seems like this one does so it is still useful

sass: sassExtendedSyntax,

You're right, I've updated my previous comment, thanks 👍

@rgant
Copy link
Author

rgant commented Mar 16, 2023

Any chance this can be merged soon? I am blocked in updating stylelint by this dependency.

@bryanjtc
Copy link

Any update on this?

@rgant
Copy link
Author

rgant commented Jun 10, 2023

I added this to my package.json to work around this apparently dead project.

  "devDependencies": {
    "stylelint-csstree-validator": "^2.1.0"
  },
  "overrides": {
    "stylelint-csstree-validator@^2.1.0": {
      "stylelint@>=7.0.0 <15.0.0": "*"
    }
  }

@lahmatiy
Copy link
Member

Very sorry in delay for an update. That's fixed in v3.0.0. The fix is also required to drop older versions of Node.js, that's why it's a major version bump due to semver.

@lahmatiy lahmatiy closed this Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants