Make sure we cache the hashCode as it will be called a lot #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cstamas
merged commit 434a5f0
into
cstamas:maven-resolver-1.9.x-MRESOLVER-587
11 checks passed
cstamas
pushed a commit
that referenced
this pull request
Aug 2, 2024
|
@cstamas Glad to have you back :) I hope you had an awesome PTO. This PR was for the 1.9.x branch, it also needs to be applied to the other PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cstamas this should help make your patch faster. We came to this conclusion in Hibernate Validator after a lot of benchmarking. Whenever you get an object that is very heavily used in HashMaps, it's often worth caching the hashCode.