Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csgrep --file-glob: expand glob patterns #212

Closed
wants to merge 1 commit into from

Conversation

kdudka
Copy link
Member

@kdudka kdudka commented Oct 15, 2024

... in the names of input files. If we have too many input files, we cannot rely on the glob expansion implemented in the shell because the expanded command might exceed the maximum command line length. Running csgrep for multiple batches of input files is difficult when we use a JSON-based output format, which cannot be concatenated as plain text.

Related: csutils/csmock#187

@kdudka kdudka requested a review from lzaoral October 15, 2024 12:23
@kdudka kdudka self-assigned this Oct 15, 2024
kdudka added a commit to kdudka/csdiff that referenced this pull request Oct 15, 2024
... in the names of input files.  If we have too many input files, we
cannot rely on the glob expansion implemented in the shell because the
expanded command might exceed the maximum command line length.  Running
`csgrep` for multiple batches of input files is difficult when we use
a JSON-based output format, which cannot be concatenated as plain text.

Related: csutils/csmock#187
Closes: csutils#212
kdudka added a commit to kdudka/csdiff that referenced this pull request Oct 15, 2024
... in the names of input files.  If we have too many input files, we
cannot rely on the glob expansion implemented in the shell because the
expanded command might exceed the maximum command line length.  Running
`csgrep` for multiple batches of input files is difficult when we use
a JSON-based output format, which cannot be concatenated as plain text.

Related: csutils/csmock#187
Closes: csutils#212
kdudka added a commit to kdudka/csmock that referenced this pull request Oct 15, 2024
... to avoid exceeding maximum command line length

Depends-on: csutils/csdiff#212
kdudka added a commit to kdudka/csmock that referenced this pull request Oct 15, 2024
... to avoid exceeding maximum command line length

Depends-on: csutils/csdiff#212
kdudka added a commit to kdudka/csmock that referenced this pull request Oct 15, 2024
... to avoid exceeding maximum command line length

Depends-on: csutils/csdiff#212
kdudka added a commit to kdudka/csdiff that referenced this pull request Oct 23, 2024
... in the names of input files.  If we have too many input files, we
cannot rely on the glob expansion implemented in the shell because the
expanded command might exceed the maximum command line length.  Running
`csgrep` for multiple batches of input files is difficult when we use
a JSON-based output format, which cannot be concatenated as plain text.

Related: csutils/csmock#187
Closes: csutils#212
kdudka added a commit to kdudka/csmock that referenced this pull request Oct 25, 2024
With https://copr.fedorainfracloud.org/coprs/dmalcolm/gcc-latest/
added to the `fedora-41-x86_64` mock config, this can be tested
using the following commands:
```
koji download-build -a src units-2.23-3.fc41
csmock -f units-2.23-3.fc41.src.rpm -r fedora-41-x86_64 --install gcc-latest --gcc-analyzer-bin /opt/gcc-latest/bin/gcc
```

Depends-on: csutils/csdiff#210
Depends-on: csutils/csdiff#212
Related: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116613
Closes: csutils#187
kdudka added a commit to kdudka/csmock that referenced this pull request Nov 5, 2024
With https://copr.fedorainfracloud.org/coprs/dmalcolm/gcc-latest/
added to the `fedora-41-x86_64` mock config, this can be tested
using the following commands:
```
koji download-build -a src units-2.23-3.fc41
csmock -f units-2.23-3.fc41.src.rpm -r fedora-41-x86_64 --install gcc-latest --gcc-analyzer-bin /opt/gcc-latest/bin/gcc
```

Depends-on: csutils/csdiff#210
Depends-on: csutils/csdiff#212
Related: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116613
Closes: csutils#187
Copy link
Member

@lzaoral lzaoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that I did not actually review the changes since I do not work this project any more.

... in the names of input files.  If we have too many input files, we
cannot rely on the glob expansion implemented in the shell because the
expanded command might exceed the maximum command line length.  Running
`csgrep` for multiple batches of input files is difficult when we use
a JSON-based output format, which cannot be concatenated as plain text.

Related: csutils/csmock#187
Closes: csutils#212
@kdudka kdudka closed this in 761b13a Nov 7, 2024
@kdudka kdudka deleted the file-glob branch November 7, 2024 13:17
kdudka added a commit to kdudka/csmock that referenced this pull request Nov 7, 2024
With https://copr.fedorainfracloud.org/coprs/dmalcolm/gcc-latest/
added to the `fedora-41-x86_64` mock config, this can be tested
using the following commands:
```
koji download-build -a src units-2.23-3.fc41
csmock -f units-2.23-3.fc41.src.rpm -r fedora-41-x86_64 --install gcc-latest --gcc-analyzer-bin /opt/gcc-latest/bin/gcc
```

Depends-on: csutils/csdiff#210
Depends-on: csutils/csdiff#212
Related: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116613
Closes: csutils#187
kdudka added a commit to kdudka/csmock that referenced this pull request Nov 7, 2024
With https://copr.fedorainfracloud.org/coprs/dmalcolm/gcc-latest/
added to the `fedora-41-x86_64` mock config, this can be tested
using the following commands:
```
koji download-build -a src units-2.23-3.fc41
csmock -f units-2.23-3.fc41.src.rpm -r fedora-41-x86_64 --install gcc-latest --gcc-analyzer-bin /opt/gcc-latest/bin/gcc
```

Depends-on: csutils/csdiff#210
Depends-on: csutils/csdiff#212
Related: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116613
Closes: csutils#187
kdudka added a commit to kdudka/csmock that referenced this pull request Nov 8, 2024
With https://copr.fedorainfracloud.org/coprs/dmalcolm/gcc-latest/
added to the `fedora-41-x86_64` mock config, this can be tested
using the following commands:
```
koji download-build -a src units-2.23-3.fc41
csmock -f units-2.23-3.fc41.src.rpm -r fedora-41-x86_64 --install gcc-latest --gcc-analyzer-bin /opt/gcc-latest/bin/gcc
```

Depends-on: csutils/csdiff#210
Depends-on: csutils/csdiff#212
Related: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=116613
Closes: csutils#187
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants