Fix/continuous delivery #834
Open
+14
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guidojw
requested changes
Mar 29, 2024
| @@ -7,6 +7,11 @@ on: | |||
| description: Merge staging into master first? (y/N) | |||
| required: false | |||
| default: 'n' | |||
There was a problem hiding this comment.
Can you make this one boolean too? I think I made it like this because boolean was not an option back in the day, but I see the UI nicely supports it now. Don't forget the checks below :)
guidojw
reviewed
Mar 29, 2024
| @@ -63,6 +63,8 @@ Deployments are done using GitHub Actions. To deploy a branch, follow the follow | |||
| - Choose a branch and if you want to merge the changes on the staging branch into the master branch (only possible when the branch chosen in previous step is master). | |||
| - Click the green button "Run workflow". | |||
|
|
|||
| *Note: If the workflow fails with an error message about blobs along the lines of the following: `buildx failed with: ERROR: failed to solve: [...] blob [...]`: remove all recent cache files for staging on the [Caches page](https://github.com/csvalpha/amber-ui/actions/caches) and try again. You might have to turn on the option `Perform all jobs, regardless of whether there are actual changes?` to force the workflow to re-execute all its jobs.* | |||
There was a problem hiding this comment.
Odd bug, could this be a one-time bug caused by https://github.blog/changelog/2023-12-14-github-actions-artifacts-v4-is-now-generally-available/? That is artifacts and not cache though, but it might be related.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the workflow fails with an error message about blobs along the lines of the following:
buildx failed with: ERROR: failed to solve: [...] blob [...]then all recent cache files for staging on the Caches page need to be deleted and the workflow needs to be executed again. Instructions for this were added to the README.md.Also added the option
Perform all jobs, regardless of whether there are actual changes?to force the workflow to re-execute all its jobs. This was added because if the previous workflow run errored after staging was merged into master it will detect no changes and skip the Continuous Integration and Publish Image jobs, which means the changes won't go live.