Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to compute multiplicities using FeatureGenerator #2308

Merged
merged 8 commits into from
Apr 27, 2023

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Apr 18, 2023

Add multiplicity method to SubarrayDescription and use a ChainMap to allow additional information to be passed to the FeatureGenerator other than the table to allow calling SubarrayDescription.multiplicity in FeatureGenerator.

@maxnoe maxnoe requested a review from kosack April 18, 2023 09:47
kosack
kosack previously approved these changes Apr 18, 2023
Copy link
Contributor

@kosack kosack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Copy link
Member

@LukasNickel LukasNickel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!
Took me a while to understand why/how this is working. Is this clear for everyone?

@maxnoe maxnoe mentioned this pull request Apr 21, 2023
@maxnoe maxnoe merged commit 4cea6a8 into main Apr 27, 2023
@maxnoe maxnoe added this to the v0.19.1 milestone May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants