Fix return value of NullDataVolumeReducer #2340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
astropy 5.3 was just released and it changed the order in which units are output as VO format string (in a good way!), I adapted the test so it doesn't care about the order |
Tobychev
approved these changes
May 31, 2023
Hckjs
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The data volume reduction classes are supposed to return a boolean mask for each pixel.
The
NullDataVolumeReducerreturned a mask for each (pixel, sample), comparing unnecessarily to 0.Now, just a all-True boolean mask with the correct shape is returned.