Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop camera frame #2396

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Drop camera frame #2396

wants to merge 1 commit into from

Conversation

StFroese
Copy link
Member

As you may remember, I already started this here #2141. A lot happened since the last time (i.e. moving the muon processing), so I decided to give this another try on a fresh branch to avoid rebasing

@StFroese
Copy link
Member Author

still one issue in tutorials/ctapipe_handson.py, seems like I'm zooming into the wrong region because of the transformation to TelescopeFrame, I'll fix it later

@maxnoe
Copy link
Member

maxnoe commented Sep 15, 2023

New traitlets version seems to come with more broken sphinx stuff in their docs, need to add to the ignore rules

@maxnoe maxnoe added this to the v0.21.0 milestone Sep 15, 2023
@kosack
Copy link
Contributor

kosack commented Sep 18, 2023

Great! This reminds me I should look back at #2279 as well once this is finished.

@maxnoe
Copy link
Member

maxnoe commented Sep 19, 2023

I added the traitlets docs fixes and the changelog

kosack
kosack previously approved these changes Sep 21, 2023
@StFroese
Copy link
Member Author

Fixed a notebook

@maxnoe
Copy link
Member

maxnoe commented Sep 22, 2023

We discussed today in the meeting that this is as much a breaking change or more than the container restructuring discussed in CEP-2, so we decided that we will also write a CEP for this change.

Technically, this looks already fine and is ready to merge.

Edit: CEP PR here: #2405

@maxnoe
Copy link
Member

maxnoe commented Nov 17, 2023

@StFroese could you update this fixing the conflict and getting the fixed codecov in?

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.60%. Comparing base (3b610d2) to head (07a6c41).

❗ Current head 07a6c41 differs from pull request most recent head 193cfb8. Consider uploading reports for the commit 193cfb8 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2396       +/-   ##
===========================================
- Coverage   92.52%   60.60%   -31.93%     
===========================================
  Files         235        3      -232     
  Lines       20024       33    -19991     
===========================================
- Hits        18528       20    -18508     
+ Misses       1496       13     -1483     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-Authored-By: Stefan Fröse <stefan.froese@udo.edu>
Co-Authored-By: Maximilian Linhoff <maximilian.linhoff@tu-dortmund.de>

This comment has been minimized.

1 similar comment
Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 96.40% Coverage (94.10% Estimated after merge)
  • Duplications 0.00% Duplicated Code (0.60% Estimated after merge)

Project ID: cta-observatory_ctapipe_AY52EYhuvuGcMFidNyUs

View in SonarQube

@maxnoe maxnoe requested a review from kosack July 12, 2024 13:24
@maxnoe maxnoe modified the milestones: 0.22.0, 0.23.0 Sep 10, 2024
@maxnoe maxnoe modified the milestones: 0.23.0, 0.24.0 Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants