-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove python warnings #2421
Remove python warnings #2421
Conversation
LukasNickel
commented
Oct 25, 2023
- Use logging of the component
- No R1 is expected, so its just debug level
- No DL0 is not expected, so keep it as warning
- Fixes CameraCalibrator warns in case no R1 data is present #2407
Ah sorry, apparently I did not have my pre-commit set up |
70c6441
to
5c5d150
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @LukasNickel, just a typo in the changelog
Maybe it's not for this PR, but the overall behavior here should be updated to be more in line with how we do the DL1 and DL2 steps. In ctapipe-process, we have methods like That way all transitions are handled in the same way, and you only need to deal with the case if the user asks explicitly for a transformation to be re-computed, but the previous data level doesn't exist in the input. And in that case it's not even a warning, but an error that should stop processing. |
- Use logging of the component - No R1 is expected, so its just debug level - No DL0 is not expected, so keep it as warning
6523d15
to
de7cb58
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2421 +/- ##
==========================================
- Coverage 92.48% 92.47% -0.01%
==========================================
Files 234 234
Lines 19831 19819 -12
==========================================
- Hits 18340 18328 -12
Misses 1491 1491 ☔ View full report in Codecov by Sentry. |