-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chunked loading of training data #2423
Conversation
be1e8d3
to
b0235ad
Compare
Is there any test that checks that the |
This looks extremely similar between the three tools. Can we refactor the code into a single common function? |
For the disp tool, the calculation of For the other two tools, I see no problem. |
b0235ad
to
9e185fe
Compare
9d0b81a
to
9815e7a
Compare
I did this now, but maybe there are better ways to do this. I also don't have a strong opinion on whether this is worth it or if we should leave it as it was before.
I haven't come up with anything useful for this yet, since most of it is already covered by the existing tests of the QualityQuery and the ChunkIterator. If you have a good idea, please let me know. |
c70d36b
to
0c8a3d7
Compare
- Since the total number of telescope events in a file is not known when loading in chunks (only the total number of subarray events), a progress bar for loading does not make sense.
0c8a3d7
to
bb01357
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2423 +/- ##
=======================================
Coverage 60.60% 60.60%
=======================================
Files 3 3
Lines 33 33
=======================================
Hits 20 20
Misses 13 13 ☔ View full report in Codecov by Sentry. |
This will fix #2413.
ctapipe-train-energy-regressor
ctapipe-train-particle-classifier
ctapipe-train-disp-reconstructor