Allow setting n_jobs on tool invocation #2430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
LukasNickel
commented
Oct 26, 2023
LukasNickel
commented
- It can be useful to set n_jobs indepently from the config file
- For the sklearn reconstructors this requires setting n_jobs on every model, that is attached to the reconstructor
- Fixes Allow overriding number of cores used by reconstructors on the CLI #2307
Tobychev
previously approved these changes
Oct 26, 2023
Tobychev
previously approved these changes
Oct 26, 2023
maxnoe
reviewed
Oct 26, 2023
maxnoe
reviewed
Oct 27, 2023
maxnoe
reviewed
Oct 27, 2023
maxnoe
reviewed
Oct 30, 2023
|
Maybe it also makes sense to set |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2430 +/- ##
==========================================
- Coverage 92.47% 92.46% -0.02%
==========================================
Files 234 234
Lines 19819 19868 +49
==========================================
+ Hits 18327 18370 +43
- Misses 1492 1498 +6 ☔ View full report in Codecov by Sentry. |
maxnoe
requested changes
Nov 17, 2023
Tobychev
previously approved these changes
Nov 17, 2023
- It can be useful to set n_jobs indepently from the config file - For the sklearn reconstructors this requires setting n_jobs on every model, that is attached to the reconstructor - Fixes #2307
- Implement the @observe method there as well, because it is not a subclass of sklearnreconstructor
- Move n_jobs from model config to reconstructor config
maxnoe
approved these changes
Nov 23, 2023
kosack
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.