-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use editable install to fix coverage #2460
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2460 +/- ##
===========================================
+ Coverage 60.60% 87.96% +27.35%
===========================================
Files 3 231 +228
Lines 33 19768 +19735
===========================================
+ Hits 20 17388 +17368
- Misses 13 2380 +2367 ☔ View full report in Codecov by Sentry. |
Using the editable install fixed coverage.py being able to associate the coverage report with the source files, so now we have correctly working coverage reports again. Please review @Tobychev @LukasNickel The muon fit fix is temporary, a proper fix is under investigation in #2425 |
I don't understand what the problem being solved is, nor why doing an editable install would matter. I don't even understand why the muon test needs to be patched in this PR, so I don't think I can provide a meaningful review. |
Codecov reports coverage of 60% on 30 lines, because it doesn't recognize the file paths being tested because we run the tests in a temporary directory using the package installed into the prefix of the python installation. See: https://app.codecov.io/gh/cta-observatory/ctapipe/
Doing an editable install means the installation is just creating symlinks to the checked out repository, which means that codecov can link the executed code to the source files correctly.
To be honest, me neither. The test started failing after I added the https://app.codecov.io/gh/cta-observatory/ctapipe/pull/2460/indirect-changes |
No description provided.