Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration for using CTAO sonarqube to check code #2463

Merged
merged 2 commits into from
Mar 25, 2024
Merged

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Nov 17, 2023

Testing sonarqube with the src layout and not changing to a tmp dir

@maxnoe
Copy link
Member Author

maxnoe commented Nov 17, 2023

mmh, still no luck:

INFO: Parsing report '/github/workspace/coverage.xml'
ERROR: Cannot resolve the file path 'src/ctapipe/__init__.py' of the coverage report, the file does not exist in all 'source'.
ERROR: Cannot resolve 244 file paths, ignoring coverage measures for those files

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.58%. Comparing base (163b543) to head (c3cb18b).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2463      +/-   ##
==========================================
+ Coverage   92.53%   92.58%   +0.05%     
==========================================
  Files         235      232       -3     
  Lines       20063    20031      -32     
==========================================
- Hits        18565    18546      -19     
+ Misses       1498     1485      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxnoe
Copy link
Member Author

maxnoe commented Nov 20, 2023

I briefly activated also push builds on pull requests to get a full report on sonarqube, not just the Pull Request diff checks, works now:

https://sonar-cta-dpps.zeuthen.desy.de/dashboard?id=ctapipe_github_9404f0f6-9294-11ed-bf3b-07aa00bdfe94&branch=sonarqube_src

@maxnoe maxnoe force-pushed the sonarqube_src branch 3 times, most recently from 2bb786a to 32a5b5e Compare February 23, 2024 09:47
@maxnoe maxnoe changed the title Sonarqube src Add configuration for using CTAO sonarqube to check code Feb 23, 2024
@maxnoe maxnoe marked this pull request as ready for review February 23, 2024 09:48
Tobychev
Tobychev previously approved these changes Feb 26, 2024
@maxnoe
Copy link
Member Author

maxnoe commented Mar 22, 2024

@kosack The direction github → Sonarqube works now. For the other direction we need to setup a Github app and configuration on the sonarqube server I think, but this is good to go

@kosack kosack merged commit f3e9239 into main Mar 25, 2024
15 checks passed
@kosack kosack deleted the sonarqube_src branch March 25, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants