Move TableLoader traits to read_...-methods
#2482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- function call for reading subarray events passes wrong parameters
- not finished yet, have to check how the sphinx gallery format works
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2482 +/- ##
==========================================
+ Coverage 92.44% 92.46% +0.01%
==========================================
Files 234 234
Lines 19917 19955 +38
==========================================
+ Hits 18413 18451 +38
Misses 1504 1504 ☔ View full report in Codecov by Sentry. |
kosack
requested changes
Dec 13, 2023
kosack
approved these changes
Dec 19, 2023
maxnoe
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #2165 and related to #2012. Thanks to @ccossou!
I've also added a new example/tutorial related to TableLoader and EventSources based on the hands-on presented in October 2023 at the DPPS Meeting at CEA Paris-Saclay.