Implement lstchains image cleaning #2541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxnoe
reviewed
Apr 23, 2024
maxnoe
reviewed
Apr 23, 2024
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
maxnoe
reviewed
Apr 23, 2024
maxnoe
reviewed
Apr 23, 2024
maxnoe
reviewed
Apr 23, 2024
maxnoe
reviewed
Apr 23, 2024
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
kosack
reviewed
Apr 24, 2024
kosack
reviewed
Apr 24, 2024
maxnoe
reviewed
Apr 24, 2024
Hckjs
force-pushed
the
lstchain_cleaning
branch
2 times, most recently
from
4e7e24a
to
4aafbab
Compare
This comment has been minimized.
This comment has been minimized.
maxnoe
reviewed
Apr 26, 2024
This comment has been minimized.
This comment has been minimized.
Hckjs
force-pushed
the
lstchain_cleaning
branch
from
67995da
to
b9a1507
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
kosack
requested changes
May 27, 2024
- instead allow time_limit and bright_cleaning_threshold to be None
- substitute it with the argsort term in the GlobalPeakWindowSum Co-authored-by: Maximilian Linhoff <maximilian.linhoff@tu-dortmund.de>
- Adding a wrapper
This comment has been minimized.
This comment has been minimized.
maxnoe
reviewed
Jun 3, 2024
maxnoe
reviewed
Jun 3, 2024
maxnoe
reviewed
Jun 3, 2024
maxnoe
reviewed
Jun 3, 2024
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
Analysis Details1 Issue
Coverage and Duplications
Project ID: cta-observatory_ctapipe_AY52EYhuvuGcMFidNyUs |
kosack
approved these changes
Jun 5, 2024
maxnoe
approved these changes
Jul 10, 2024
|
Would there be the possibility of patching this lstchain cleaning algo to ctapipe v.19.x in order to already use it on LST-1 data with |
|
We don't maintain patch releases at the moment, and starting to do one for new features instead of for security fixes or critical bugs is not something I intend to do. We should update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the
ImageCleaners API in #2511 now allows to make use of monitoring information in the cleaning process.This enables implementing lstchains image cleaning procedure from its r0_to_dl1 script and dl1ab script including the 'pedestal cleaning' method.