New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error messages for non-existing path #2591

Merged

kosack merged 2 commits into main from fix_traits

Sep 11, 2024

Member

maxnoe commented Jul 15, 2024 •

edited

Loading

Fixes #1881

Now:

❯ ctapipe-process --config /does/not/exist
2024-07-15 17:27:04,877 CRITICAL [ctapipe.ctapipe-process] (application.inner): Bad config encountered during initialization: The 'config_files' trait of a ProcessorTool instance contains a Path of a List which expected a pathlib.Path or non-empty str for an existing file, not the PathError '/does/not/exist': does not exist.

Tobychev previously approved these changes

View reviewed changes

maxnoe force-pushed the fix_traits branch from afe5f41 to 4bca44a Compare

July 15, 2024 19:04

maxnoe dismissed Tobychev’s stale review via

a8df05e

July 15, 2024 19:29

maxnoe force-pushed the fix_traits branch from 4bca44a to a8df05e Compare

July 15, 2024 19:29

Tobychev previously approved these changes

View reviewed changes

maxnoe dismissed Tobychev’s stale review via

9e637a3

July 16, 2024 09:08

ctao-dpps-sonarqube bot commented Jul 16, 2024

Analysis Details

0 Issues

0 Bugs
0 Vulnerabilities
0 Code Smells

Coverage and Duplications

85.70% Coverage (94.20% Estimated after merge)
0.00% Duplicated Code (0.60% Estimated after merge)

Project ID: cta-observatory_ctapipe_AY52EYhuvuGcMFidNyUs

View in SonarQube

maxnoe requested review from Tobychev and kosack

September 5, 2024 14:18

maxnoe added 2 commits

September 5, 2024 16:19


          Move help to correct position

3287e15


          Add missing info to exceptions

f217ede

maxnoe force-pushed the fix_traits branch from 6c249aa to f217ede Compare

September 5, 2024 14:22

Tobychev approved these changes

View reviewed changes

kosack approved these changes

View reviewed changes

kosack merged commit 4b85d1f into main

12 checks passed

maxnoe added this to the 0.22.0 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet