Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete tel attribute from MonitoringCameraContainer in NSBImageCleaner #2602

Merged
merged 3 commits into from
Jul 31, 2024

Conversation

Hckjs
Copy link
Contributor

@Hckjs Hckjs commented Jul 24, 2024

Fixes #2601
Adding MonitoringCameraContainer to tests

 - It tried to reach the .tel attribute from the
   MonitoringCameraContainer
@Hckjs Hckjs requested review from maxnoe and kosack July 24, 2024 09:55

This comment has been minimized.

1 similar comment
Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 100.00% Coverage (94.20% Estimated after merge)
  • Duplications 0.00% Duplicated Code (0.60% Estimated after merge)

Project ID: cta-observatory_ctapipe_AY52EYhuvuGcMFidNyUs

View in SonarQube

@maxnoe maxnoe merged commit 5d6116c into main Jul 31, 2024
13 checks passed
@maxnoe maxnoe deleted the fix_nsb_image_cleaner branch July 31, 2024 12:02
@maxnoe maxnoe added this to the 0.22.0 milestone Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NSBImageCleaner tries to reach the tel attribute from the MonitoringCameraContainer
3 participants