This repository has been archived by the owner on Feb 8, 2022. It is now read-only.
Froto.Parser & Froto.Serialization target netstandard2.0 #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #76. This moves over Froto.Parser & Froto.Serialization to target netstandard2.0 which is available for every major platform but Unity (soon). The Froto.TypeProvider was bumped from
net45tonet461which is the minimum framework version compatible with netstandard2.0.I think that the Froto.TypeProvider should probably wait for type providers to work without the full framework installed.
dotnet/fsharp#2406
dotnet/fsharp#3303
https://github.com/fsprojects/FSharp.TypeProviders.SDK
netcore also doesn't have System.Runtime.Caching https://github.com/dotnet/corefx/issues/14529, so a depenency will need to be added to the preview https://www.nuget.org/packages/System.Runtime.Caching/ or an alternative like http://cachemanager.michaco.net.
This pull request manually puts slashes instead of backslashes in the sln files as a workaround for:
MSB4025 could not load metaproj
dotnet/msbuild#1957