Cross compatible #114
Merged
Cross compatible #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The changes seem reasonable to me. I haven't yet got an npmjs.com account. Will get to that shortly and send you the details. |
- Create module/index.js that will be used for running the package - Make the node addon file have the OS name tagged on the end - Update README.md - Update bindings for newer version of nodejs - Create release CI to create release and upload tarball file to github - Also publishes to the npm regsitry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple Updates:
module/omega_editrelease.ymlthat will create a release tarball of the current code and upload it to gitlab@scholarsmate If you don't have an account already, create an account for npmjs.com and send me the username so I can add you to
omega-editpackage.After this you will need to create an access token and save it as GitHub Secret named
NPM_TOKEN.This will be used for when a tag is pushed the omega-edit package will be published.
Here is release built by the CI https://github.com/Shanedell/omega-edit/releases/tag/v0.6.1-1. Here is the CI job for that release https://github.com/Shanedell/omega-edit/actions/runs/1632789428. I was able to successfully install
omega-edit@0.6.1-1and can run it should also be able to do it from Linux, plan to work on the windows one in a separate PR