Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java Bindings #138

Merged
merged 6 commits into from
Jan 10, 2022
Merged

Java Bindings #138

merged 6 commits into from
Jan 10, 2022

Conversation

shanedell
Copy link
Collaborator

Easiest way to test out the API is:

  • download the omega-edit-java zip
  • extract and cd into the folder
  • run ./bin/omega-edit.
  • browse to http://localhost:9000/omega_license_get in the browser and you should get the license text
  • For Mac:
    • You need to go to System Preferences >> Security and Privacy >> General and Allow Access for libomega_edit.dylib
      • This may not show up till you run the server
    • After access has been given when you try to hit the API you will get a prompt to Open the libomega_edit.dylib file

@jw3
Copy link
Member

jw3 commented Jan 6, 2022

Usually when automatically generating bindings you would not commit them as Java files to a repo. They would instead be packaged and published as a binary artifact. Maintaining these thousands of lines of auto generated code will be tiring.

@shanedell
Copy link
Collaborator Author

Oh my bad, I didn't mean to add them must have forgot to update the gitignore to ignore them will fix that now

@shanedell
Copy link
Collaborator Author

So gitignore did have proper item to ignore them but they must have got added during my rebase by mistake

@scholarsmate
Copy link
Member

The copyright years are incorrect. I've been using 2021-2022.

src/examples/omega_copy.js Outdated Show resolved Hide resolved
@shanedell shanedell requested a review from scholarsmate January 8, 2022 01:24
Copy link
Member

@scholarsmate scholarsmate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shanedell
Copy link
Collaborator Author

@scholarsmate I am going to wait to merge it till I fix the release of sbt so that it makes 4 different files. It will have the tar.gz for the node release, then a .jar file for linux, mac and windows

@shanedell shanedell merged commit 50fefcd into ctc-oss:main Jan 10, 2022
@shanedell shanedell deleted the java branch January 10, 2022 01:28
@scholarsmate scholarsmate added this to the v0.7.0 milestone Jan 10, 2022
@scholarsmate scholarsmate added the bindings Language bindings label Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bindings Language bindings
Projects
Development

Successfully merging this pull request may close these issues.

3 participants