-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java Bindings #138
Java Bindings #138
Conversation
Usually when automatically generating bindings you would not commit them as Java files to a repo. They would instead be packaged and published as a binary artifact. Maintaining these thousands of lines of auto generated code will be tiring. |
Oh my bad, I didn't mean to add them must have forgot to update the gitignore to ignore them will fix that now |
So gitignore did have proper item to ignore them but they must have got added during my rebase by mistake |
The copyright years are incorrect. I've been using 2021-2022. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@scholarsmate I am going to wait to merge it till I fix the release of sbt so that it makes 4 different files. It will have the |
Easiest way to test out the API is:
omega-edit-java
zip./bin/omega-edit
.http://localhost:9000/omega_license_get
in the browser and you should get the license textOpen
thelibomega_edit.dylib
file