Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduced support for the s3 proxying #74

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alekc
Copy link
Contributor

@alekc alekc commented Jun 8, 2020

This is probably should not be merged for now, I am bringing it here to show how we fixed things following our discussion on slack.

To reassume things:

  • current version of sdk doesn't handle webidentity when used on kubernetes through tokens requiring update
  • once updated due to aws/aws-sdk-go@3f5879a goiardi will no longer be able to create a proper signed urls for cookbook uploads because knife sends malformed host parameter when downloading stuff.

I left current behaviour as it is, and introduced a new config var use-s3-proxy, which permits to upload cookbooks directly through /filestore/ endpoint.

Initial tests went well, but if this is merged it's going to be a breaking change for users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant