-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: CRC is unexpectedly changed after zip is re-created #267
Conversation
After this pull f472a1d#diff-64d795f6b4ed8e1a2d32c759f6c8f383 merged in, the compression behaviour is different from what is in the version I also want this PR needed to be merged asap as my app is not working without this fix. When i can expect this PR to be merged and released? |
This PR will fix the 7-zip "Headers Error" with files created by adm-zip@0.4.13. Please merge asap. Thanks! |
@cthackers : We need the fix asap, as the tool we use is unable to understand the new compression mechanism and this PR is gonna fix it. |
@SowmyaGrama I've used this https://www.npmjs.com/package/patch-package to patch my project. Perhaps this might me a temporary solution for you too. |
@cthackers Can you please get this PR merged , we need this fix for our app |
This PR makes my .docx generate files work again. Currently, Microsoft Word states the .docx file (just a .zip file) is corrupt. It repairs it OK, but you have to click "Yes, fix the corrupt document file." When applying the change to my local adm-zip install, all works fine. Thanks @teppeis. @cthackers, can you please merge this PR? |
merge this PR plz, |
With |
cthackers/adm-zip#267 In our case, we could unzip fine, but in 7zip it reported: "Headers Error" and in the Ubuntu 19.10 gnome extracting app, it would say "empty archive" and "An error occurred while loading the archive."
- Update zip process to copy over Webpack build directory content instead of copying & creating a "build" folder inside the zip file. - Upgrade `adm-zip` to latest version (v0.4.14) to get CRC fix in cthackers/adm-zip#267
- Update zip process to copy over Webpack build directory content instead of copying & creating a "build" folder inside the zip file. - Upgrade `adm-zip` to latest version (v0.4.14) to get CRC fix in cthackers/adm-zip#267
This was fixed in #228, but broken by #240 again!
data.writeInt32LE(_crc & 0xFFFF, Constants.CENCRC)
breaks crc over 0xFFFF.Also adding test code to
test/crc/index.js
and run it in CI.