Skip to content
This repository has been archived by the owner on Aug 27, 2024. It is now read-only.

1.0.2 #406

Merged
merged 13 commits into from
Jun 25, 2020
Merged

1.0.2 #406

merged 13 commits into from
Jun 25, 2020

Conversation

Portals
Copy link
Member

@Portals Portals commented Jun 25, 2020

Solves all issues in milestone v1.0.2

@Portals Portals added this to the v1.0.2 milestone Jun 25, 2020
@Portals Portals requested a review from Hoidi as a code owner June 25, 2020 12:55
@Portals
Copy link
Member Author

Portals commented Jun 25, 2020

I have published on npm: @cthit/react-digit.components@1.0.2-alpha.0

Comment on lines +7 to +12
const useFullFlex = makeStyles({
root: {
flex: "1"
}
});

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference between this and what was before?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was having a performance issue in DigitTextArea for Gamma, I'm guessing this was the issue with calling makeStyles every render.

Copy link
Member

@Hoidi Hoidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it works 🤷 It didn't crash at least

@Hoidi
Copy link
Member

Hoidi commented Jun 25, 2020

I'm guessing #399 is resolved in 079c575. #405 tho?

@Portals
Copy link
Member Author

Portals commented Jun 25, 2020

@Hoidi #405 shouldn't be in v1.02, my bad!

Right now testing the new version in mat and gamma!

@Portals Portals merged commit ad5f5d5 into master Jun 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants