Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow annotating models and routes using sorbet's static checks #1029

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

wteuber
Copy link

@wteuber wteuber commented Sep 3, 2024

This PR allows Annotate to recognize and keep Sorbet's static checks sigils.

Diff after running annotate for models and routes with Sorbet static check sigils:

Before

-# typed: true
 # frozen_string_literal: true
 
+# == Schema Information
+#
+# Table name: …
+#
+#  …
+#
+# typed: true
+

After

 # typed: true
 # frozen_string_literal: true
 
+# == Schema Information
+#
+# Table name: …
+#
+#  …
+#

@wteuber wteuber force-pushed the allow-annotating-models-and-routes-using-sorbet-s-static-checks branch 3 times, most recently from 00e4b9a to 7bd8553 Compare September 3, 2024 19:04
@wteuber wteuber force-pushed the allow-annotating-models-and-routes-using-sorbet-s-static-checks branch from 7bd8553 to 8529224 Compare September 3, 2024 19:08
@ctran ctran self-assigned this Sep 16, 2024
@ctran ctran added this to the v3.2.1 milestone Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants