Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support REDIS_PASSWORD env variable #280

Merged
merged 1 commit into from
Dec 1, 2019

Conversation

lanphan
Copy link
Contributor

@lanphan lanphan commented Nov 29, 2019

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

[For example #12]

Description of Changes Made (if issue reference is not provided)
As my Redis instance has password, I did add configuration for Redis here to support password.

[Description goes here]

@paveltiunov
Copy link
Member

@lanphan Hey Lan! Overall looks great! Did you have a chance to test it without providing any env variables?

@lanphan
Copy link
Contributor Author

lanphan commented Nov 30, 2019

Hi @paveltiunov pave,
Not yet ... let I check right now and let you know.

@lanphan
Copy link
Contributor Author

lanphan commented Nov 30, 2019

Hi @paveltiunov ,
It works with configuration below:

  1. docker-compose.yml starts official redis container:
    redis-test:
      image: redis:latest
      restart: unless-stopped
      networks:
        - backend
  1. .env file of cubejs only with REDIS_URL:
REDIS_URL=redis://redis-test:6379/0
  1. runs Playground ok, can query and display chart well.

@paveltiunov
Copy link
Member

@lanphan Sounds great! Thanks again!

@paveltiunov paveltiunov merged commit 5172745 into cube-js:master Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants