Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump corejs #378

Merged
merged 4 commits into from
Feb 15, 2020
Merged

Bump corejs #378

merged 4 commits into from
Feb 15, 2020

Conversation

cemremengu
Copy link
Contributor

@cemremengu cemremengu commented Feb 14, 2020 •
edited
Loading

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Try bumping corejs so we dont get the deprecation warning during install

@hassankhan
Copy link
Contributor

@cemremengu Thanks for making the PR - I'd been meaning to since I was finding the deprecation warning annoying 😅

@pavel It may be an idea to use something like Dependabot. It'll scan and create PRs for all available dependencies, and can even be configured to automerge PRs if all tests pass.

@cemremengu
Copy link
Contributor Author

+1 for dependabot or any other tool that can make the global upgrades across the entire repo easier

@cemremengu
Copy link
Contributor Author

I have had some nice experience with greenkeeper regarding this

@paveltiunov
Copy link
Member

@hassankhan Thanks for suggestion! Just enabled Dependabot for the repo.

@paveltiunov paveltiunov merged commit cb8d51c into cube-js:master Feb 15, 2020
paveltiunov added a commit that referenced this pull request Feb 20, 2020
@paveltiunov
fix: Revert "feat: Bump corejs (#378)"
b21cbe6 
Hold on with core-js@3 update until it's default babel depend
Fixes #418

This reverts commit cb8d51c.
@snyk-bot snyk-bot mentioned this pull request Jun 16, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cemremengu @hassankhan @paveltiunov