New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CONTRIBUTING.md #379

Merged

paveltiunov merged 1 commit into cube-js:master from cemremengu:patch-1

Feb 14, 2020

Contributor

cemremengu commented Feb 14, 2020 •

edited

Loading

Check List

Tests has been run in packages where changes made if available
Linter has been run for changed code
Tests for the changes have been added if not covered yet
Docs have been added / updated if required


          Update CONTRIBUTING.md

90a40c3

Member

paveltiunov commented Feb 14, 2020

@cemremengu Hey Cemre! Thanks for fixing this one!

paveltiunov merged commit 768ff50 into cube-js:master

cemremengu deleted the patch-1 branch

February 14, 2020 16:46

Contributor

hassankhan commented Feb 14, 2020

Good catch @cemremengu, I missed this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet