feat(schema-compiler): choose preaggregation with the exact granularity for the query if it exists #8696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 8 Skipped Deployments
|
KSDaemon
changed the base branch from
master
to
feat/date_bin_cubestorequery
KSDaemon
force-pushed
the
feat/date_bin_cubestorequery
branch
from
0ae1b29
to
85417d9
Compare
…r time dimensions
…r time dimensions (simple syntax)
…resolution (proxied custom granularities)
…ed custom granularities)
…iece to cubeReferenceProxy
KSDaemon
force-pushed
the
feat/date_bin_cubestorequery
branch
from
85417d9
to
9f52bf7
Compare
KSDaemon
force-pushed
the
feat/date_bin_cubestorequery
branch
from
9f52bf7
to
13ebe9b
Compare
…ty for the query if it exists
KSDaemon
force-pushed
the
feat/findPreAggregationForQuery-improve
branch
from
270ee0c
to
b4d9004
Compare
KSDaemon
force-pushed
the
feat/date_bin_cubestorequery
branch
2 times, most recently
from
8cdba10
to
f8c2d25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
findPreAggregationForQuery()logic to try to choose the preaggregation with the exact same granularity from the potentially applicable list. This especially makes sense when using custom granularity in the query and if there is a related preAggregation.Related to:
Check List