Generalise async executor code #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomwhite
force-pushed
the
generalize-async-executor
branch
from
cb11122
to
b885825
Compare
tomwhite
force-pushed
the
generalize-async-executor
branch
from
b885825
to
5e11421
Compare
|
The batching code needs more work (e.g. removing completed tasks from data structures), so I've removed it from this PR and will add separately later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the logic for async executors into a common function, which can be used for an async Dask Distributed executor later.
Also adds a
batch_sizeargument to address #239 for Modal (and Python async).