Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal progress fix #522

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Modal progress fix #522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cubed/runtime/executors/modal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ async def async_execute_dag(
) -> None:
if spec is not None:
check_runtime_memory(spec)
async with app.run():
async with app.run(show_progress=False):
cloud = cloud or "aws"
if cloud == "aws":
app_function = run_remotely
Expand Down
2 changes: 1 addition & 1 deletion cubed/tests/runtime/test_modal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ def deterministic_failure_modal_long_timeout(

async def run_test(app_function, input, use_backups=False, batch_size=None, **kwargs):
outputs = set()
async with app.run():
async with app.run(show_progress=False):
async for output in map_unordered(
app_function,
input,
Expand Down
Loading