Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename to clear_with_dataframe #1032

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Conversation

MariusWirtz
Copy link
Collaborator

Successor of #1026

@MariusWirtz
Copy link
Collaborator Author

@151N3 please review and approve.

I renamed it to comply with existing functions in the service like clear_with_mdx or write_dataframe
I also added more type-checking. I understand that for dimensions with elements in the dataframe the dimension_mapping must provide a single hierarchy. For dimensions that are not included in the dataframe, the dimension_mapping can provide a list of hierarchies. Ist that correct?

@151N3
Copy link
Contributor

151N3 commented Jan 23, 2024

@151N3 please review and approve.

I renamed it to comply with existing functions in the service like clear_with_mdx or write_dataframe I also added more type-checking. I understand that for dimensions with elements in the dataframe the dimension_mapping must provide a single hierarchy. For dimensions that are not included in the dataframe, the dimension_mapping can provide a list of hierarchies. Ist that correct?

Yes, you are corret, just as small detail, if dimensions are not included in the dataframe you can provide one hierarchy as a string or a list of hierarchies. But it can be a list of one as well. Its just for lazy people that don't want to make a list with one element 😄

Copy link
Contributor

@151N3 151N3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @MariusWirtz ,
looks much better now. Thank you

TM1py/Services/CellService.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants