Issue/empty string as nan in attribute #1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mdx_dataframe function. By passing the empty_dimension_attribute_as_string we expect the resulting dataframe to contain empty strings for empty string attribute values requested as dimension properties in an mdx.
… to the build_dataframe_from_csv function.
Passing attribute_types_by_dimension allows fillna('') for string attributes while avoiding filling numeric attributes with empty strings in case they have to be loaded as str.
Passing empty_string_attribute_as_string indicates whether nan should be filled with '' for string attributes. Default is False, for backwards compatibility.
…types by dimension based on retrieved cellset.
…or backward compatibility
MariusWirtz
force-pushed
the
issue/empty-string-as-nan-in-attribute
branch
from
de9ca52 to
7a16e06
Compare
|
@Kevin-Dekker I had to make a few small adjustments but now all tests pass. Please take a look at my changes 7a16e06 and approve |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Kevin-Dekker I cherry-picked your commits on top of the current master.