Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skip_non_updateable arg to write function #657

Merged
merged 2 commits into from
Dec 22, 2021

Conversation

MariusWirtz
Copy link
Collaborator

Handy new argument to skip cells that are not updateable.

Fixes #651

@MariusWirtz
Copy link
Collaborator Author

Performance impact of new argument quantified below:

Scenario1: 100k updateable cells + 100k non updateable cells

use_ti skip_non_updateable Elapsed Time
TRUE TRUE 00:00:33
FALSE TRUE 00:01:25
TRUE FALSE 00:01:25
FALSE FALSE 00:01:25

Scenario2: 200k updateable cells

use_ti skip_non_updateable Elapsed Time
TRUE TRUE 00:00:36
FALSE TRUE 00:01:57
TRUE FALSE 00:00:14
FALSE FALSE 00:00:52

All tests run on localhost.

@MariusWirtz
Copy link
Collaborator Author

@dsfomichev, @gbryant-dev
Any thoughts on this approach?

Handy new argument to skip cells that are not updateable.

Fixes #651
@MariusWirtz MariusWirtz force-pushed the feature/skip-non-updateable branch from 507844f to 0e57ab5 Compare December 17, 2021 14:47
@gbryant-dev
Copy link
Contributor

I like it. I've left a comment just to get your thoughts on one approach over the other 🙂

The performance impact when testing with the first scenario and skip_non_updateable is False is interesting compared to second scenario when all cells are updateable. Presumably, the write failures are slowing the processing down.

@rkvinoth
Copy link
Contributor

The performance metrics looks very useful and provides an idea of when to use this parameter.
Thanks @MariusWirtz

@MariusWirtz
Copy link
Collaborator Author

Thanks for the feedback @gbryant-dev and @rkvinoth

I implemented your suggestions.

@MariusWirtz MariusWirtz merged commit f19f58b into master Dec 22, 2021
@MariusWirtz MariusWirtz deleted the feature/skip-non-updateable branch April 9, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skip rule calculated cells when writing
3 participants