Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for new search functions #660

Merged
merged 1 commit into from
Jan 6, 2022

Conversation

MariusWirtz
Copy link
Collaborator

Align search function names. Always prefix with search_

Successor of #658

Align search function names. Always prefix with `search_`

Successor of #658
@MariusWirtz
Copy link
Collaborator Author

@adscheevel
I made a few small adjustments. Please verify my changes and approve the pull request.

@adscheevel
Copy link
Collaborator

@MariusWirtz I like the "search" prefix and other refactoring you did, thanks! A good learning for me as well. I see how you removed any spaces right in the odata query, good call.

@MariusWirtz MariusWirtz merged commit 4205676 into master Jan 6, 2022
@MariusWirtz
Copy link
Collaborator Author

Thanks!

@MariusWirtz MariusWirtz deleted the feature/add-tests-for-search-functions branch April 9, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants