Element functions #792
Merged
Element functions #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
function will return list of parents by element for all elements
2 functions to get consolidated elements and names
two functions to get numeric elements and names
two new functions to get string elements and names
two functions to return count of numeric and string elements
tests for new numeric and string element functions as well as get_parents_all_elements
MariusWirtz
reviewed
Aug 20, 2022
MariusWirtz
reviewed
Aug 20, 2022
rename function to `get_parents_of_all_elements`
update for function rename `get_parents_of_all_elements`
|
Nice work @adscheevel Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added new functions to element service for string and numeric elements. I've also added a
get_parents_all_elementsfunction which is similar toget_parentsbut instead of taking an element argument, will return parents for all elements in dim.I've taken a stab at the tests for these new functions. I wrapped all of the string element testing in one function because I add a string function to test and then immediately delete. This seemed better than adding it when the class is created, seemed like it could mess up some other tests.