Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add get values #954

Closed
wants to merge 3 commits into from

Conversation

raeldor
Copy link
Contributor

@raeldor raeldor commented Aug 7, 2023

Created rudimentary get_values() function where you can pass in a list of data point keys and get back a list of values. This way you don't have to make multiple trips.

raeldor added 3 commits August 3, 2023 21:26
Add get_values()
Update get_values description
More comments
@rclapp
Copy link
Collaborator

rclapp commented Aug 7, 2023

Can you update this to use MDXpy for MDX generation? We should avoid manual mdx generation going forward as it can make future compatibility hard to manage. MDXpy provides a good layer of abstraction.

Can you add the required tests for the new methods?

@MariusWirtz
Copy link
Collaborator

Thanks for the contribution @raeldor

I agree with @rclapp. Let's use mdxpy where we can. There might be some changes to MDX necessary with the upcoming TM1 v12 release. If we externalize the MDX construction to mdxpy that makes our lives easier.

Please add a test case similar to this one:

def test_get_value(self):

@raeldor
Copy link
Contributor Author

raeldor commented Oct 18, 2023

Can someone with more better Python skills than me code this using MDXpy? I'm not familiar with it, and not sure when I will get time to round back on this. Thanks.

@MariusWirtz
Copy link
Collaborator

closed in favor of #1020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants