Skip to content
This repository has been archived by the owner on Jun 28, 2022. It is now read-only.

Commit

Permalink
Nddipiazza address issue 1662 (#1985)
Browse files Browse the repository at this point in the history
* some initial commits towards https://github.com/cucumber/common/issues/1662

* finish the Pretty document stuff.

* add some gitignores

* code formatting.

* maven-itize the project
do my best at trying to add the make and gherkin-ish stuff

* add more of the other files

* javadoc

* add comments.

* the formatting of numbers on the left side caused differences with intellij's auto formatter which is not good.
fixed a couple other differences between IntelliJ's auto formatter
fixed some comment formatting issues.

* pr review

* handle end of file comments.

* fix broken test

* fix ci issue

* add entry for gherkin-util/java in ci config.yaml

* try to fix config error

* try to fix config error

* try removing it

* Revert "fix ci issue"

This reverts commit a9a30cb01f60abb6ba572ed8a7f29705554bf936.

* more fixes

* fix typo in name

* add commited files for ci

* push untracked files

* fix gherkin patch m2

* fix package names to match project

* push source

* fix remaining issues with make

* push source

* push untracked files

* push untracked files

* Update dependencies and refactor

* Refactor

* Limit API surface area

* Add dependency on gherkin-java

Co-authored-by: Nicholas DiPiazza <nicholas.dipiazza@gmail.com>
Co-authored-by: Nicholas DiPiazza <nicholas.dipiazza@lucidworks.com>
Co-authored-by: Nicholas DiPiazza <nicholas.dipiazza@wpsic.com>
Co-authored-by: Jamie Tanna <github@jamietanna.co.uk>
  • Loading branch information
5 people authored May 23, 2022
1 parent b4a8cfb commit f954a0d
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions java-testdata/scripts/check-jar.sh
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,11 @@ set -uf -o pipefail
check_jar() {
jar="$1"
module_name=$(xmlstarlet sel -N pom="http://maven.apache.org/POM/4.0.0" -t -m "//pom:project.Automatic-Module-Name" -v . pom.xml)
module_path=$(echo $module_name | sed "s/\./\\\\\//g")
echo "Checking contents of ${jar}"
module_path=$(echo $module_name | sed "s/\./\\\\\//g" | sed "s/-/\\\\\//g")
echo "Checking contents of ${jar} to see if it matches pattern: ${module_path}"
unshaded_classes=$(unzip -l ${jar} | grep -e "\.class" | rev | cut -d' ' -f1 | rev | grep -v "^$module_path")
if [[ "${unshaded_classes}" != "" ]]; then
echo "Some classes in ${jar} are not in the io.cucumber package. Rename the classes or change the maven-shade-plugin configuration."
echo "Some classes in ${jar} are not in the expected package matching pattern ${module_path}. Rename the classes or change the maven-shade-plugin configuration."
echo
echo "${unshaded_classes}"
exit 1
Expand Down

0 comments on commit f954a0d

Please sign in to comment.