Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency protox to v1 #1194

Merged
merged 1 commit into from
Sep 29, 2020

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Sep 27, 2020

This PR contains the following updates:

Package Update Change
protox major ~> 0.25.0 -> ~> 1.0.0

Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot force-pushed the renovate/protox-1.x branch 3 times, most recently from 9311a98 to fd8098e Compare September 28, 2020 19:06
@aslakhellesoy
Copy link
Contributor

Is this ok to merge @WannesFransen1994 ?

@renovate renovate bot force-pushed the renovate/protox-1.x branch from fd8098e to de7b9a0 Compare September 28, 2020 20:14
@renovate renovate bot force-pushed the renovate/protox-1.x branch from de7b9a0 to 73e3d01 Compare September 29, 2020 08:55
@aslakhellesoy
Copy link
Contributor

Does this look good to you @WannesFransen1994 ?

@WannesFransen1994
Copy link
Contributor

Looks good! The mix.lock file should be committed though
Confirmed with generating the messages file again (from the proto file) and trying out the gherkin parser. Behaves exactly the same.

@aslakhellesoy aslakhellesoy merged commit 103aa8c into master Sep 29, 2020
@aslakhellesoy aslakhellesoy deleted the renovate/protox-1.x branch September 29, 2020 11:08
@aslakhellesoy
Copy link
Contributor

Great - added mix.lock in fac6319

@mpkorstanje
Copy link
Contributor

touch .rsynced
[[ -z $(git status -s) ]] || ( \
	echo "Working copy is dirty. Please run 'source scripts/functions.sh && rsync_files' and commit modified files." && \
	echo "Found: " && \
	git status -s && \
	exit 1 \
)
Working copy is dirty. Please run 'source scripts/functions.sh && rsync_files' and commit modified files.
Found: 
 D messages/elixir/mix.lock
make: *** [Makefile:42: check_synced] Error 1

@WannesFransen1994 looks like the lock file is modified with when building. Any idea why? I've removed it from the repo for now.

@WannesFransen1994
Copy link
Contributor

WannesFransen1994 commented Oct 1, 2020

I'm not sure, but after looking at the CircleCI logs the following was shown:

#!/bin/bash -eo pipefail
cd messages/elixir
make

touch .deps
mix test
Could not find Hex, which is needed to build dependency :protox
Shall I install Hex? (if running non-interactively, use "mix local.hex --force") [Yn] ** (Mix) Could not find an SCM for dependency :protox from CucumberMessages.MixProject

Think something is going wrong in the Makefile (hex is only installed in the mix.lock section of the makefile, not sure), causing hex not to be installed. I'll investigate this tomorrow and write a PR!


default: .tested

.tested: .deps $(ELIXIR_SOURCE_FILES)
	mix test
	touch $@

.deps: mix.lock
	touch $@

mix.lock: mix.exs
	mix local.hex --force
	mix deps.get

@WannesFransen1994
Copy link
Contributor

Sorry for the delay. Referring to #1204 to add the mix.lock file (without failing the build). Had to make changes to the Makefile (not so experienced in this), a review would be appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants